Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement assert_equal_vector_char_pointer using gtest matcher. #14036

Closed
wants to merge 1 commit into from
Closed

Implement assert_equal_vector_char_pointer using gtest matcher. #14036

wants to merge 1 commit into from

Conversation

benjaminp
Copy link
Collaborator

This makes the failure output richer.

@google-cla google-cla bot added the cla: yes label Sep 24, 2021
@oquenchil oquenchil self-assigned this Sep 27, 2021
@oquenchil oquenchil added team-Rules-CPP Issues for C++ rules team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Rules-CPP Issues for C++ rules labels Sep 27, 2021
@oquenchil oquenchil self-requested a review February 16, 2022 14:45
oquenchil
oquenchil approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bazel-io bazel-io closed this in eed6e61 Feb 17, 2022
@benjaminp benjaminp deleted the assert_equal_vector_char_pointer branch February 17, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees

@oquenchil oquenchil

Labels
cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminp @oquenchil