Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit collect_coverage.sh early if LCOV_MERGER is not set. #14352

Closed
wants to merge 1 commit into from
Closed

Exit collect_coverage.sh early if LCOV_MERGER is not set. #14352

wants to merge 1 commit into from
+131 −0

Commits on Dec 1, 2021

  1. Exit collect_coverage.sh early if LCOV_MERGER is not set. 

    Rules that provide InstrumentedFilesInfo but do not define the
_lcov_merger attribute will result in this script being called without
the required LCOV_MERGER environment variable being set.

Since _all_ rules now provide an InstrumentedFilesInfo provider by
default, but are not required to provide the attribute, this scenario
will be encountered far more frequently and should not be an error.

Because of the way coverage collection within Google differs to Bazel,
it isn't safe to change TestActionBuilder to simply not prepare the
collect_coverage.sh script the way it would if no coverage was to be
collected, so we have to change the script itself.
    @c-mita
    c-mita committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    2da7ab8 View commit details
    Browse the repository at this point in the history