Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for select() #14458

Closed
wants to merge 2 commits into from
Closed

Improve documentation for select() #14458

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 21, 2021

  • Reference documentation that explains when to use Label rather than a label string.
  • Remove mention of constraint_settings as they can't be used as select keys.

@fmeum
Improve documentation for select()
e0d010a 
* Reference documentation that explains when to use Label rather than a
  label string.
* Remove mention of constraint_settings as they can't be used as select
  keys.
@fmeum fmeum mentioned this pull request Dec 21, 2021
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 21, 2021

@gregestren

gregestren
gregestren approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@gregestren gregestren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this followup.

I didn't even notice the bug about constraint_setting, nice catch.

FYI because of the holidays this PR may take more time than usual to get merged. Apologies for that, but we'll get it in.

@bazel-io bazel-io closed this in 67a133b Jan 6, 2022
@fmeum fmeum deleted the 14259-allow-label-in-select branch January 6, 2022 21:40
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 4, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 4, 2022
@meteorcloudy
Copy link
Member

@bazel-io fork 5.1

@bazel-io bazel-io mentioned this pull request Feb 4, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Feb 4, 2022
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Feb 9, 2022
@fmeum @brentleyjones
Improve documentation for select()
b9b82d8 
* Reference documentation that explains when to use Label rather than a label string.
* Remove mention of constraint_settings as they can't be used as select keys.

Closes bazelbuild#14458.

PiperOrigin-RevId: 420129541
(cherry picked from commit 67a133b)
Wyverald pushed a commit that referenced this pull request Feb 9, 2022
@brentleyjones @fmeum
Improve documentation for select() (#14769)
58ecec3 
* Reference documentation that explains when to use Label rather than a label string.
* Remove mention of constraint_settings as they can't be used as select keys.

Closes #14458.

PiperOrigin-RevId: 420129541
(cherry picked from commit 67a133b)

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren gregestren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @meteorcloudy @gregestren @bazel-io