Remote: Postpone the block waiting in afterCommand to BlockWaitingModule
#14618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also fix the fact that |
|
My gut feeling is yes but do we have an issue already where I can learn more details from? |
meisterT
approved these changes
Jan 25, 2022
src/main/java/com/google/devtools/build/lib/runtime/BlockWaitingModule.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/runtime/BlockWaitingModule.java
Outdated
Show resolved
Hide resolved
|
@Wyverald This fixes a 5.0 regression. Can we add it to the 5.0.1 milestone? |
|
The linked issue is already on the milestone :) |
meisterT
reviewed
Jan 26, 2022
src/main/java/com/google/devtools/build/lib/runtime/BlockWaitingModule.java
Outdated
Show resolved
Hide resolved
meisterT
approved these changes
Jan 26, 2022
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 16, 2022
…Module` When implementing async upload, we introduced a block waiting behaviour in `RemoteModule#afterCommand` so that uploads happened in the background can be waited before the whole build complete. However, there are other block waiting code in other module's `afterCommand` method (e.g. BES module). Block waiting in remote module will prevent other modules' `afterCommand` from executing until it's completed. This causes issues like bazelbuild#14576. This PR adds a new module `BlockWaitingModule` whose sole purpose is to accept tasks submitted by other modules in `afterCommand` and block waiting all the tasks in its own `afterCommand` method. So those tasks can be executed in parallel. This PR only updates RemoteModule's `afterCommand` method to submit block waiting task. Other modules should be updated to use `BlockWaitingModule` as well but that's beyond the scope this this PR. This PR along with 73a76a8 fix bazelbuild#14576. Closes bazelbuild#14618. PiperOrigin-RevId: 424295121 (cherry picked from commit 621649d)
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 16, 2022
…Module` When implementing async upload, we introduced a block waiting behaviour in `RemoteModule#afterCommand` so that uploads happened in the background can be waited before the whole build complete. However, there are other block waiting code in other module's `afterCommand` method (e.g. BES module). Block waiting in remote module will prevent other modules' `afterCommand` from executing until it's completed. This causes issues like bazelbuild#14576. This PR adds a new module `BlockWaitingModule` whose sole purpose is to accept tasks submitted by other modules in `afterCommand` and block waiting all the tasks in its own `afterCommand` method. So those tasks can be executed in parallel. This PR only updates RemoteModule's `afterCommand` method to submit block waiting task. Other modules should be updated to use `BlockWaitingModule` as well but that's beyond the scope this this PR. This PR along with 73a76a8 fix bazelbuild#14576. Closes bazelbuild#14618. PiperOrigin-RevId: 424295121 (cherry picked from commit 621649d)
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 16, 2022
…Module` When implementing async upload, we introduced a block waiting behaviour in `RemoteModule#afterCommand` so that uploads happened in the background can be waited before the whole build complete. However, there are other block waiting code in other module's `afterCommand` method (e.g. BES module). Block waiting in remote module will prevent other modules' `afterCommand` from executing until it's completed. This causes issues like bazelbuild#14576. This PR adds a new module `BlockWaitingModule` whose sole purpose is to accept tasks submitted by other modules in `afterCommand` and block waiting all the tasks in its own `afterCommand` method. So those tasks can be executed in parallel. This PR only updates RemoteModule's `afterCommand` method to submit block waiting task. Other modules should be updated to use `BlockWaitingModule` as well but that's beyond the scope this this PR. This PR along with 73a76a8 fix bazelbuild#14576. Closes bazelbuild#14618. PiperOrigin-RevId: 424295121 (cherry picked from commit 621649d)
Wyverald
pushed a commit
that referenced
this pull request
Feb 16, 2022
…Module` (#14833) When implementing async upload, we introduced a block waiting behaviour in `RemoteModule#afterCommand` so that uploads happened in the background can be waited before the whole build complete. However, there are other block waiting code in other module's `afterCommand` method (e.g. BES module). Block waiting in remote module will prevent other modules' `afterCommand` from executing until it's completed. This causes issues like #14576. This PR adds a new module `BlockWaitingModule` whose sole purpose is to accept tasks submitted by other modules in `afterCommand` and block waiting all the tasks in its own `afterCommand` method. So those tasks can be executed in parallel. This PR only updates RemoteModule's `afterCommand` method to submit block waiting task. Other modules should be updated to use `BlockWaitingModule` as well but that's beyond the scope this this PR. This PR along with 73a76a8 fix #14576. Closes #14618. PiperOrigin-RevId: 424295121 (cherry picked from commit 621649d) Co-authored-by: Chi Wang <chiwang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing async upload, we introduced a block waiting behaviour in
RemoteModule#afterCommandso that uploads happened in the background can be waited before the whole build complete.However, there are other block waiting code in other module's
afterCommandmethod (e.g. BES module). Block waiting in remote module will prevent other modules'afterCommandfrom executing until it's completed. This causes issues like #14576.This PR adds a new module
BlockWaitingModulewhose sole purpose is to accept tasks submitted by other modules inafterCommandand block waiting all the tasks in its ownafterCommandmethod. So those tasks can be executed in parallel.This PR only updates RemoteModule's
afterCommandmethod to submit block waiting task. Other modules should be updated to useBlockWaitingModuleas well but that's beyond the scope this this PR.This PR along with 73a76a8 fix #14576.