Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolibSymlinkAction does not need exec platform or properties #14827

Closed
wants to merge 1 commit into from
Closed

SolibSymlinkAction does not need exec platform or properties #14827

wants to merge 1 commit into from

Conversation

glukasiknuro
Copy link
Contributor

@glukasiknuro glukasiknuro force-pushed the glukasik/solibsymlink-change-key branch from f31157d to 9f6e52e Compare February 16, 2022 07:47
@glukasiknuro glukasiknuro mentioned this pull request Feb 16, 2022
Closed
@glukasiknuro glukasiknuro marked this pull request as ready for review February 16, 2022 08:17
@aiuto aiuto requested a review from comius February 26, 2022 01:52
@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label Mar 23, 2022
@comius comius requested review from oquenchil and removed request for comius and lberki April 1, 2022 13:30
@jlaxson
Copy link
Contributor

jlaxson commented Apr 14, 2022 •
edited
Loading

I'd like to suggest this should be a blocker for the 5.x series. It is a regression from 4.2, appears to have a viable fix ready, and the underlying issue doesn't seem to have a workaround.

@jlaxson
Copy link
Contributor

jlaxson commented Apr 14, 2022

@bazel-io flag

1 similar comment
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 15, 2022
@ckolli5
Copy link

ckolli5 commented Apr 19, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io mentioned this pull request Apr 19, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 19, 2022
oquenchil
oquenchil approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 5, 2022
@meteorcloudy meteorcloudy added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 10, 2022
@bazel-io bazel-io closed this in 519d2da May 11, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 11, 2022
@ckolli5 ckolli5 mentioned this pull request May 12, 2022
Merged
ckolli5 added a commit that referenced this pull request May 12, 2022
@ckolli5 @glukasiknuro
SolibSymlinkAction does not need exec platform or properties (#15474)
707e8d4 
#14826

Closes #14827.

PiperOrigin-RevId: 447948011

Co-authored-by: Grzegorz Lukasik <glukasik@nuro.ai>
copybara-service bot pushed a commit that referenced this pull request Feb 9, 2023
@comius @copybara-github
Remove exec platform and properties from SymlinkAction
cde4b7b 
Similar to #14827
When C++ toolchain is built for toolchains, exec platform is set and when it's built for `_cc_toolchain` implicit dependency it's not set.

With this and in specific configuration `cc_toolchain` rule causes an action conflict.

PiperOrigin-RevId: 508270931
Change-Id: I316f401f454fabc4e5e3d8d295e1bf633141e1af
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@comius @hvadehra
Remove exec platform and properties from SymlinkAction
bbcdfae 
Similar to #14827
When C++ toolchain is built for toolchains, exec platform is set and when it's built for `_cc_toolchain` implicit dependency it's not set.

With this and in specific configuration `cc_toolchain` rule causes an action conflict.

PiperOrigin-RevId: 508270931
Change-Id: I316f401f454fabc4e5e3d8d295e1bf633141e1af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@glukasiknuro @jlaxson @brentleyjones @ckolli5 @oquenchil @meteorcloudy @bazel-io @sgowroji