Commits on Mar 15, 2022

1. Do not validate input-only settings in transitions …

   Starlark transition logic temporarily explicitly sets all input build
   settings of a transition to their defaults. Since bazelbuild#13971, these values
   are cleared after the transition. However, since then they have also
   been subject to type validation, which is not only unnecessary, but
   also breaks in the special case of a string build setting with
   allow_multiple.
   
   With this commit, input-only build settings are unconditionally
   stripped from the post-transition BuildOptions and do not undergo
   validation. This is made possible by a refactoring of
   `StarlarkTransition#validate` that extracts the validation logic into a
   separate function and also improves some variable names.
   
   Fixes bazelbuild#14894
   
   Closes bazelbuild#14972.
   
   PiperOrigin-RevId: 434589143

   

   fmeum committed Mar 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for f60f4c8
   • Browse repository at this point

   Copy the full SHA

   f60f4c8 View commit details

   Browse the repository at this point in the history