Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Remote: Don't upload action result if declared outputs are not created. #15050

Commits on Mar 15, 2022

  1. Remote: Don't upload action result if declared outputs are not created.

    Even if the exit code is 0. Missing declared outputs will be detected by Bazel later and fail the build, so avoid uploading this false positive cache entry.
    
    Wrap buildUploadManifest inside a `Single.fromCallable` since there are many IOs (both the check we add in this PR and stats already there). If `--experimental_remote_cache_async` is set, these IOs will now be executed in a background thread.
    
    Fixes bazelbuild#14543.
    
    Closes bazelbuild#15016.
    
    PiperOrigin-RevId: 434448255
    (cherry picked from commit 5b54588)
    coeuvre authored and brentleyjones committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    731ff97 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Remote: Check declared outputs when downloading outputs.

    An AC entry that misses declared outputs of an action is invalid because, if Bazel accepts this from remote cache, it will detect the missing declared outputs error at a later stage and fail the build.
    
    This PR adds a check for mandatory outputs when downloading outputs from remote cache. If a mandatory output is missing from AC entry, Bazel will ignore the cache entry so build can continue.
    
    Also fixes an issue introduced by bazelbuild#15016 that tests result are not uploaded to remote cache. Test spawns declare all the possible outputs but they usually don't generate them all. This change fixes that by only check for mandatory outputs via `spawn.isMandatoryOutput()`.
    
    Fixes bazelbuild#14543.
    
    Closes bazelbuild#15051.
    
    PiperOrigin-RevId: 435307260
    (cherry picked from commit a151116)
    coeuvre authored and brentleyjones committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    e83e050 View commit details
    Browse the repository at this point in the history