Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect C++ lcov coverage if runtime object not in runfiles #15118

Closed
wants to merge 1 commit into from
Closed

Collect C++ lcov coverage if runtime object not in runfiles #15118

wants to merge 1 commit into from

Commits on Mar 24, 2022

  1. Collect C++ lcov coverage if runtime object not in runfiles 

    Before this commit, collecting C++ coverage in lcov format would fail
at the llvm-cov export step if a shared library listed in the
runtime_objects_list.txt was not contained in the runfiles of the top-
level target. This can happen e.g. if a cc_library depends on a
java_binary that has a cc_binary shared library in its resources.

This is fixed by not including objects that don't exist at runtime
in the llvm-cov invocation.
    @fmeum
    fmeum committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c12ff67 View commit details
    Browse the repository at this point in the history