Add field check_preceding_lifecycle_events_present to PublishLifecycleEventRequest and PublishBuildToolEventStreamRequest protos. #15247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eEventRequest and PublishBuildToolEventStreamRequest protos.
|
I can merge this for you. Dealing with third_party is a little different from the normal procedures. |
|
That would be amazing! Thanks! |
sgowroji
added
the
team-Core
sgowroji
added
the
awaiting-review
|
Green team: Please review. |
aiuto
added
team-OSS
aiuto
added a commit
to aiuto/bazel
that referenced
this pull request
Apr 21, 2022
|
Moved to #15315 |
bazel-io
pushed a commit
that referenced
this pull request
Apr 22, 2022
…eEventRequest and PublishBuildToolEventStreamRequest protos. Closes #15247. Signed-off-by: Yun Peng <pcloudy@google.com> test #15247 Signed-off-by: Yun Peng <pcloudy@google.com> missing Signed-off-by: Yun Peng <pcloudy@google.com> piggly wiggly Signed-off-by: Yun Peng <pcloudy@google.com> spelling Partial commit for third_party/*, see #15315. Closes #15315 Signed-off-by: Yun Peng <pcloudy@google.com>
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add field check_preceding_lifecycle_events_present to PublishLifecycleEventRequest and PublishBuildToolEventStreamRequest protos so that they match the internal versions of those protos. This change is needed so that subsequent changes to files in /src/main/java/com/google/devtools/build/lib/buildeventservice that refer to this field don't break.
A corresponding change was made to the googleapis repo: googleapis/googleapis@a877d3d