Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom jdk_compiler and java_compiler jars #15303

Closed
wants to merge 1 commit into from
Closed

Remove custom jdk_compiler and java_compiler jars #15303

wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Apr 20, 2022

The javac changes that Bazel depends on are now available in the latest JDK 11 update release.

#14533

@cushon
Copy link
Contributor Author

cushon commented Apr 20, 2022

This depends on #15302, which should be merged first

@cushon
Copy link
Contributor Author

cushon commented Apr 20, 2022

Also I'm not sure if removing the :jdk_compiler_jar etc. targets from the Java tools repo is acceptable because users could be referring to those labels directly. We could also remove the uses of them in the default toolchain config, but leave the artifacts around for now, and delete them later.

@cushon cushon force-pushed the jdkcompiler branch 2 times, most recently from 31366c4 to 9225f9d Compare April 20, 2022 20:18
@cushon cushon mentioned this pull request Apr 20, 2022
Closed
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Apr 21, 2022
@sgowroji sgowroji requested a review from comius April 21, 2022 03:31
@sgowroji sgowroji added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 21, 2022
@cushon
Remove custom jdk_compiler and java_compiler jars
b6be8b9 
The javac changes that Bazel depends on are now available in the latest
JDK 11 update release.

bazelbuild#14533
cushon added a commit to cushon/bazel that referenced this pull request Apr 22, 2022
@cushon
Remove langtools jars
5f1ac29 
Follow-up to bazelbuild#15303
cushon added a commit to cushon/bazel that referenced this pull request Apr 22, 2022
@cushon
Remove langtools jars
03773e4 
Follow-up to bazelbuild#15303
@cushon cushon mentioned this pull request Apr 22, 2022
Closed
@bazel-io bazel-io closed this in 18c17da Apr 22, 2022
cushon added a commit to cushon/bazel that referenced this pull request Apr 22, 2022
@cushon
Remove langtools jars
fe506c0 
Follow-up to bazelbuild#15303
cushon added a commit to cushon/bazel that referenced this pull request Apr 22, 2022
@cushon
Remove langtools jars
5353fb3 
Follow-up to bazelbuild#15303
cushon added a commit to cushon/bazel that referenced this pull request Apr 22, 2022
@cushon
Remove langtools jars
eddf708 
Follow-up to bazelbuild#15303
bazel-io pushed a commit that referenced this pull request Apr 26, 2022
@cushon @copybara-github
Remove langtools jars
3a0a4f3 
Follow-up to #15303

#14533

Closes #15319.

PiperOrigin-RevId: 444583929
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cushon @comius @sgowroji @ShreeM01