Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chocolatey package CPMR0031 - docsUrl must be a valid URL #15369

Closed
wants to merge 1 commit into from
Closed

Fix chocolatey package CPMR0031 - docsUrl must be a valid URL #15369

wants to merge 1 commit into from

Conversation

petemounce
Copy link
Contributor

@petemounce petemounce commented Apr 29, 2022 •
edited
Loading

chocolatey does automated tests on package submissions.

One of those is that the docsUrl element must not "be invalid". https://docs.chocolatey.org/en-us/community-repository/moderation/package-validator/rules/cpmr0031

Broken:

image

Fixed:

{pending}

image

@petemounce petemounce changed the title Fix chocolatey package - docsUrl must not 404 Fix chocolatey package CPMR0031 - docsUrl must be a valid URL Apr 29, 2022
@ckolli5 ckolli5 added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Apr 29, 2022
@ckolli5 ckolli5 requested a review from gregestren April 29, 2022 13:49
@ulfjack
Copy link
Contributor

ulfjack commented Apr 29, 2022

Not sure why the old URL didn't work and the new one does.

@petemounce
Copy link
Contributor Author

Me either; I didn't see anything more specific in the log out documentation.

@Yannic
Copy link
Contributor

Yannic commented May 1, 2022

@bazel-io fork 5.2.0

@Yannic
Copy link
Contributor

Yannic commented May 1, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 1, 2022
@Yannic
Copy link
Contributor

Yannic commented May 1, 2022

I don't think team-Configurability is right here, this should probably be team-OSS.

It would also be great if we could add a redirect from /contribute/getting-started to /start to not break old releases.

cc @fweikert

@aiuto aiuto added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels May 3, 2022
@aiuto aiuto requested review from fweikert and removed request for gregestren May 3, 2022 19:08
@aiuto aiuto self-assigned this May 3, 2022
@aiuto aiuto self-requested a review May 3, 2022 19:11
@aiuto
Copy link
Contributor

aiuto commented May 3, 2022

Trying to merge now. cl/446257778

@petemounce petemounce mentioned this pull request May 3, 2022
Merged
@bazel-io bazel-io closed this in ff9cfe0 May 4, 2022
@ckolli5
Copy link

ckolli5 commented May 4, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io mentioned this pull request May 4, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto aiuto approved these changes

@fweikert fweikert Awaiting requested review from fweikert

Assignees

@aiuto aiuto

Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petemounce @ulfjack @Yannic @aiuto @ckolli5 @bazel-io