Include spawn metrics in the execution log. #15413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
execlog-spawnmetrics
branch
3 times, most recently
from
9f3c412 to
876bb49
Compare
sgowroji
added
team-Remote-Exec
|
One thing we usually do is diffing execution logs from two builds to troubleshoot cache hits. Adding spawn metrics could probably add noise to the diff. But I do think we need include spawn metrics somewhere. @meisterT WDYT? |
The SpawnMetrics proto is intended to match the existing Java class of the same name. Note that the SpawnExec.walltime field becomes redundant, but it is kept to ensure backwards compatibility. This change makes it easier to correlate the metrics for corresponding actions in two different builds.
|
Put the inclusion of spawn metrics in the log behind a flag, per offline discussion. |
coeuvre
approved these changes
May 9, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SpawnMetrics proto is intended to match the existing Java class of the
same name. Note that the SpawnExec.walltime field becomes redundant, but it
is kept to ensure backwards compatibility.
This change makes it easier to correlate the metrics for corresponding actions
in two different builds.