Add -no_deduplicate for darwin dbg/fastbuild #15635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -no_deduplicate linker flag saves some time for debug builds at the cost of binary size. In testing envoy the difference was 50s -> 9s to link a debug build with this flag enabled. This change enables it as a separate feature so it can be opted out of by users if needed, and leaves the default for opt to get this optimization for release builds. Fixes bazelbuild#10910
sgowroji
added
team-Rules-CPP
|
@sgowroji bump |
oquenchil
requested review from
googlewalt
and removed request for
oquenchil
googlewalt
approved these changes
Sep 20, 2022
brentleyjones
approved these changes
Sep 20, 2022
|
FYI I made a couple of NFCs to the PR, to be more consistent with our internal toolchain. |
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
The -no_deduplicate linker flag saves some time for debug builds at the cost of binary size. In testing envoy the difference was 50s -> 9s to link a debug build with this flag enabled. This change enables it as a separate feature so it can be opted out of by users if needed, and leaves the default for opt to get this optimization for release builds. Fixes bazelbuild#10910 Closes bazelbuild#15635. PiperOrigin-RevId: 475592901 Change-Id: I8746ffa9492ebffed52dd680c3dd4e0283772447
|
If I'm reading correctly, this change was first released in bazel 6.0.0? I don't see it mentioned in the release notes, though. This caused a 9% increase in our build farm disk use, which was severe enough that we needed to opt-out of this feature. For that reason, I think it might be worth adding this to the release notes retroactively, so that it's easier for others to discover what might have changed to cause the bloat they're seeing when they upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -no_deduplicate linker flag saves some time for debug builds at the
cost of binary size. In testing envoy the difference was 50s -> 9s to
link a debug build with this flag enabled. This change enables it as a
separate feature so it can be opted out of by users if needed, and
leaves the default for opt to get this optimization for release builds.
Fixes #10910