target pattern file: allow comments #15903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/target-pattern-file-comment
branch
from
27f6487
to
5681ba2
Compare
sgowroji
added
team-OSS
Wyverald
requested changes
Jul 19, 2022
src/main/java/com/google/devtools/build/lib/runtime/commands/TargetPatternsHelper.java
Outdated
Show resolved
Hide resolved
sluongng
force-pushed
the
sluongng/target-pattern-file-comment
branch
from
5681ba2
to
aeae3a4
Compare
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file.
sluongng
force-pushed
the
sluongng/target-pattern-file-comment
branch
from
aeae3a4
to
43b4b64
Compare
|
unclear why gona rebase on top of latest master to see if it gets better. |
|
That's a flaky test, no need to worry :) |
Wyverald
approved these changes
Jul 19, 2022
Wyverald
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
ckolli5
pushed a commit
to ckolli5/bazel
that referenced
this pull request
Jul 19, 2022
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file. Closes bazelbuild#15903. PiperOrigin-RevId: 461861131 Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f
sgowroji
added a commit
that referenced
this pull request
Jul 20, 2022
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file. Closes #15903. PiperOrigin-RevId: 461861131 Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f Co-authored-by: Son Luong Ngoc <sluongng@gmail.com> Co-authored-by: Gowroji Sunil <48122892+sgowroji@users.noreply.github.com>
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file. Closes bazelbuild#15903. PiperOrigin-RevId: 461861131 Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
`--target_pattern_file` could be a great tool assisting migration of a code base from one Bazel config to another. User could define a list of targets that can be built with the new configs and incrementally expand that list with each change that was introduced. Multiple users / teams could collaborate on such migration by adding / removing their targets into / from the pattern file. Having the ability to provide comments to annotate the targets in the pattern file with extra information during the migration process added a great value and context for build maintainers to track migration progress. Add support for Bash-style comments to the target-pattern file. Closes bazelbuild#15903. PiperOrigin-RevId: 461861131 Change-Id: I401f71fcf1e343c8689424979e4f48fb723fba9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--target_pattern_filecould be a great tool assisting migration of acode base from one Bazel config to another. User could define a list of
targets that can be built with the new configs and incrementally expand
that list with each change that was introduced. Multiple users / teams
could collaborate on such migration by adding / removing their targets
into / from the pattern file.
Having the ability to provide comments to annotate the targets in the
pattern file with extra information during the migration process added a
great value and context for build maintainers to track migration
progress.
Add support for Bash-style comments to the target-pattern file.