-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CommandLinePathFactory to CommandEnvironment #15905
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
requested changes
Jul 18, 2022
src/main/java/com/google/devtools/build/lib/runtime/CommandEnvironment.java
Outdated
Show resolved
Hide resolved
PTAL |
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Jul 18, 2022
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Jul 18, 2022
sgowroji
added
the
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
label
Jul 19, 2022
@tjgq ping? |
tjgq
approved these changes
Jul 20, 2022
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 22, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15905. PiperOrigin-RevId: 462369707 Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
ckolli5
pushed a commit
to ckolli5/bazel
that referenced
this pull request
Jul 22, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15905. PiperOrigin-RevId: 462369707 Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
tjgq
pushed a commit
to tjgq/bazel
that referenced
this pull request
Jul 25, 2022
Progress on bazelbuild#15856 Closes bazelbuild#15905. PiperOrigin-RevId: 462369707 Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
ckolli5
added a commit
that referenced
this pull request
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #15856