Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommandLinePathFactory to CommandEnvironment #15905

Closed
wants to merge 2 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Jul 18, 2022

Progress on #15856

@Yannic Yannic marked this pull request as ready for review July 18, 2022 17:57
@Yannic
Copy link
Contributor Author

Yannic commented Jul 18, 2022

PTAL

@Yannic
Copy link
Contributor Author

Yannic commented Jul 18, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 18, 2022
@ckolli5
Copy link

ckolli5 commented Jul 18, 2022

@bazel-io fork 5.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 18, 2022
@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Jul 19, 2022
@Yannic
Copy link
Contributor Author

Yannic commented Jul 20, 2022

@tjgq ping?

sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 22, 2022
Progress on bazelbuild#15856

Closes bazelbuild#15905.

PiperOrigin-RevId: 462369707
Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
ckolli5 pushed a commit to ckolli5/bazel that referenced this pull request Jul 22, 2022
Progress on bazelbuild#15856

Closes bazelbuild#15905.

PiperOrigin-RevId: 462369707
Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
tjgq pushed a commit to tjgq/bazel that referenced this pull request Jul 25, 2022
Progress on bazelbuild#15856

Closes bazelbuild#15905.

PiperOrigin-RevId: 462369707
Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f
ckolli5 added a commit that referenced this pull request Jul 25, 2022
Progress on #15856

Closes #15905.

PiperOrigin-RevId: 462369707
Change-Id: If8dd493227b67dd4ffe30c9e0af4d8f71de4fb9f

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants