Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux to Windows cross compilation of py_binary, java_binary and sh_binary using MinGW #16019

Closed
wants to merge 11 commits into from
Closed

Fix Linux to Windows cross compilation of py_binary, java_binary and sh_binary using MinGW #16019

wants to merge 11 commits into from

Commits on Aug 2, 2022

  1. Remove incorrect exec config transition for java_binary, py_binary an… 

    …d sh_binary Windows launcher

The launcher needs to run on the target platform, not the execution platform.
    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7b8bb0d View commit details
    Browse the repository at this point in the history

  2. Fix Windows detection when cross compiling java_binary, py_binary and… 

    … sh_binary
    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    29be9a1 View commit details
    Browse the repository at this point in the history

  3. Fix Windows java launcher MinGW compatibility

    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    3ad5b34 View commit details
    Browse the repository at this point in the history

  4. Make the Windows Java launcher fully statically linked

    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    bfbb0be View commit details
    Browse the repository at this point in the history

  5. Set C++ standard version to C++17 on all launcher targets 

    - Fixes compiling launcher_main.cc with old MinGW which defaults to an old version of C++ without make_unique.
- Solves an error with using 10'000'000 syntax on old GCC.
- Provides std::filesystem for java_launcher.cc
    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7abb6b1 View commit details
    Browse the repository at this point in the history

  6. Allow backslashes in input to AsWindowsPathImpl(), they will be norma… 

    …lised by bazel::windows::Normalize() anyway
    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    05ebbf5 View commit details
    Browse the repository at this point in the history

  7. Move compiler constraints on Windows toolchains from exec platform to… 

    … target platform
    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    3dfd8f5 View commit details
    Browse the repository at this point in the history

  8. Add msvc compiler constraint to MSVC toolchains

    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    8f03b44 View commit details
    Browse the repository at this point in the history

  9. Fix missing l modifier when formatting wchar_t*

    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    694e0f3 View commit details
    Browse the repository at this point in the history

  10. Link launcher binary with -municode on MinGW

    @jesseschalken
    jesseschalken committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    55995fe View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge remote-tracking branch 'origin/master' into fix-windows-launche… 

    …r-on-mingw
    @jesseschalken
    jesseschalken committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    7e567bb View commit details
    Browse the repository at this point in the history