Correctly report errors thrown by CommandLinePathFactory#create. #16022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazel-io fork 5.3.0 |
This method is called while initializing the remote module [1]. Any exceptions not derived from java.io.IOException cause a silent server crash. [1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba
coeuvre
approved these changes
Aug 2, 2022
Yannic
reviewed
Aug 2, 2022
| @@ -99,6 +100,9 @@ public void createWithNamedRoot() throws Exception { | |||
| .isEqualTo(filesystem.getPath("/path/to/output/base/foo")); | |||
| assertThat(factory.create(ImmutableMap.of(), "%output_base%/foo/bar")) | |||
| .isEqualTo(filesystem.getPath("/path/to/output/base/foo/bar")); | |||
|
|
|||
| assertThat(factory.create(ImmutableMap.of(), "%workspace%//foo//bar")) | |||
There was a problem hiding this comment.
It seems gratuitous to disallow double-slashes when most other command-line utilities handle them correctly; in addition, we get it for free through PathFragment.create. We could even avoid the edge case by converting the whole string to a PathFragment before regex-matching the first segment, but I wanted to do the bare minimum to avoid complicating the cherry pick.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
team-Remote-Exec
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Aug 3, 2022
This method is called while initializing the remote module [1]. Any exceptions not derived from java.io.IOException cause a silent server crash. [1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba Closes bazelbuild#16022. PiperOrigin-RevId: 464997904 Change-Id: I87fd5eaeb562d849bb830d68f1bfbbf06f6e0ea9
sgowroji
added a commit
that referenced
this pull request
Aug 3, 2022
) This method is called while initializing the remote module [1]. Any exceptions not derived from java.io.IOException cause a silent server crash. [1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba Closes #16022. PiperOrigin-RevId: 464997904 Change-Id: I87fd5eaeb562d849bb830d68f1bfbbf06f6e0ea9 Co-authored-by: Tiago Quelhas <tjgq@google.com>
ShreeM01
added a commit
that referenced
this pull request
Aug 9, 2022
* Updated Codeowners file (#16032) * Propagate the error message when a credential helper fails. (#16030) Closes #16012. PiperOrigin-RevId: 464732834 Change-Id: If51ce914098ff17ffe23fa4614947e7f4a5088dc Co-authored-by: Tiago Quelhas <tjgq@google.com> * Migrate legacy desugar wrapper to new rlocation() (#16025) RELNOTES: Fix for desugaring failure on Bazel+Android+Windows build scenario. PiperOrigin-RevId: 464654335 Change-Id: I845093b134dc68ae541603008fe7fee701c7451c Co-authored-by: Gowroji Sunil <48122892+sgowroji@users.noreply.github.com> * Correctly report errors thrown by CommandLinePathFactory#create. (#16036) This method is called while initializing the remote module [1]. Any exceptions not derived from java.io.IOException cause a silent server crash. [1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba Closes #16022. PiperOrigin-RevId: 464997904 Change-Id: I87fd5eaeb562d849bb830d68f1bfbbf06f6e0ea9 Co-authored-by: Tiago Quelhas <tjgq@google.com> * Fix an issue that `incompatible_remote_build_event_upload_respect_no_… (#16045) * Fix an issue that `incompatible_remote_build_event_upload_respect_no_… …cache` doesn't work with BwtB. The root cause is we use `Path` as key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted. This change fixes that by using `PathFragment` as key. Fixes #15527. Closes #16023. PiperOrigin-RevId: 465284879 Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71 * Update ByteStreamBuildEventArtifactUploader changes Removing the import as it is throwing the error Co-authored-by: Chi Wang <chiwang@google.com> Co-authored-by: Tiago Quelhas <tjgq@google.com> Co-authored-by: Ted <tedx@google.com> Co-authored-by: Gowroji Sunil <48122892+sgowroji@users.noreply.github.com> Co-authored-by: Chi Wang <chiwang@google.com>
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is called while initializing the remote module [1]. Any exceptions
not derived from java.io.IOException cause a silent server crash.
[1] https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java;l=436;drc=f3211f00ae08746b5794ab01d404c32b43146aba