-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RunfilesLibraryInfo #16125
Add RunfilesLibraryInfo #16125
Conversation
The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards bazelbuild#16124
Hey Fabian, @Wyverald showed me the error you were getting with this in testNoRunfilesLibraryUsers. But I'm confused why you need this provider, I thought in the proposal we had concluded that we can use the existing runfiles provider. Why do you need to know if the dependency is actually giving you runfiles or not? If you do need to know, I think you can get to the runfiles from the DefaultInfo provider and check if the depset of files is empty or not. |
@oquenchil This is a bit confusing, so let me try to clarify the situation: The The Thanks for looking into the test failure, please let me know if you want additional clarifications. |
Thanks for the clarification Fabian. You are getting a Skyframe error and I'm not very familiar with it. @Wyverald will be asking around though. In the mean time, it might help them if you can upload the whole change that produces this error. |
@oquenchil I pushed the failing test as a new commit 7304185 on #16126. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sgowroji could you import this? Thanks! |
The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards bazelbuild#16124 Closes bazelbuild#16125. PiperOrigin-RevId: 470966227 Change-Id: Ie9b4dc69bdd4d8f85485fa04efa347ebbd07b8b5
*** Reason for rollback *** We're no longer going with this approach. *** Original change description *** Add RunfilesLibraryInfo The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards #16124 Closes #16125. PiperOrigin-RevId: 483622668 Change-Id: I599d588cbed27c08466cc1311779925bd39a77fc
*** Reason for rollback *** We're no longer going with this approach. *** Original change description *** Add RunfilesLibraryInfo The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards #16124 Closes #16125. PiperOrigin-RevId: 483622668 Change-Id: I599d588cbed27c08466cc1311779925bd39a77fc
*** Reason for rollback *** We're no longer going with this approach. *** Original change description *** Add RunfilesLibraryInfo The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards #16124 Closes #16125. PiperOrigin-RevId: 483622668 Change-Id: I599d588cbed27c08466cc1311779925bd39a77fc
*** Reason for rollback *** We're no longer going with this approach. *** Original change description *** Add RunfilesLibraryInfo The new provider marks runfiles libraries as such and will be used by both Bazel itself and language rules to emit additional information required for executable targets to find their runfiles in the presence of repository mappings. Work towards bazelbuild#16124 Closes bazelbuild#16125. PiperOrigin-RevId: 483622668 Change-Id: I599d588cbed27c08466cc1311779925bd39a77fc
The new provider marks runfiles libraries as such and will be used by
both Bazel itself and language rules to emit additional information
required for executable targets to find their runfiles in the presence
of repository mappings.
Work towards #16124