Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use True instead of 1 in the documentation #16165

Closed
wants to merge 1 commit into from
Closed

Use True instead of 1 in the documentation #16165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/google/devtools/build/lib/rules/genrule/GenRuleBaseRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ expanded to Windows style paths (with backslash).

/* <!-- #BLAZE_RULE(genrule).ATTRIBUTE(output_to_bindir) -->
<p>
If set to 1, this option causes output files to be written into the <code>bin</code>
If set to True, this option causes output files to be written into the <code>bin</code>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the documentation is rendered saying default is False and not default is 0
https://bazel.build/reference/be/general#genrule.local

directory instead of the <code>genfiles</code> directory.
</p>
<!-- #END_BLAZE_RULE.ATTRIBUTE --> */
Expand All @@ -259,7 +259,7 @@ expanded to Windows style paths (with backslash).

/* <!-- #BLAZE_RULE(genrule).ATTRIBUTE(local) -->
<p>
If set to 1, this option forces this <code>genrule</code> to run using the "local"
If set to True, this option forces this <code>genrule</code> to run using the "local"
strategy, which means no remote execution, no sandboxing, no persistent workers.
</p>
<p>
Expand Down