Reenable the UDS proxy tests. #16189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
uds-tests
branch
2 times, most recently
from
ebdeb54
to
8d63c1f
Compare
These tests were disabled due to flakiness in 8e3c0df. As a consequence, we introduced an undetected regression in 5.3 (bazelbuild#16171). I've rerun the tests multiple times, both locally and remotely, and I've seen no evidence of flakiness. Therefore, I'm declaring that this issue has mysteriously fixed itself. Notes: * Use `python3` instead of `python` to run the UDS proxy, as the latter is no longer available in some of the environments where the tests run. * The correct URI syntax for a Unix domain socket URI is unix:///path/to/socket rather than unix:/path/to/socket, as the URI technically has no host component. The latter form still works due to lenient parsing in the gRPC gRPC library, but this may change in the future, so the tests should exercise the correct form. Fixes bazelbuild#16185.
ShreeM01
added
team-Remote-Exec
coeuvre
approved these changes
Aug 30, 2022
|
Closing as we discussed offline that the test is still flaky. Feel free to reopen if you have time to look at this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were disabled due to flakiness in 8e3c0df. As a consequence, we
introduced an undetected regression in 5.3 (#16171).
I've rerun the tests multiple times, both locally and remotely, and I've seen
no evidence of flakiness. Therefore, I'm declaring that this issue has
mysteriously fixed itself.
Notes:
python3instead ofpythonto run the UDS proxy, as the latter is nolonger available in some of the environments where the tests run.
rather than unix:/path/to/socket, as the URI technically has no host
component. The latter form still works due to lenient parsing in the gRPC
gRPC library, but this may change in the future, so the tests should exercise
the correct form.
Fixes #16185.