-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop exporting language modules #16295
Conversation
private static final ImmutableSet<PackageIdentifier> allowedRepositories = | ||
ImmutableSet.of( | ||
PackageIdentifier.createUnchecked("_builtins", ""), | ||
PackageIdentifier.createUnchecked("rules_android", ""), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI, this won't work with Bzlmod. The module rules_android
won't have the repo name rules_android
, but something like rules_android~1.2.3
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Very helpful!
After this, how does one call |
Via |
Ahh, I didn't see that rules_cc was being revived. Thanks! Does rules_cc have all of the changes to the crosstool/toolchain that have been made to Bazel recently? I recall that when people used rules_cc in the past they would get old macOS crosstool/toolchain behaviors, and we've been recommending they remove the use: envoyproxy/envoy#19760. |
I've unclogged the pipelines!
I don't know... feel free to push the changes... |
cc: @keith Will rules_cc become the canonical location? The issue we had before was it was hard to keep both up to date (going through review on both, dealing with versioning issues, etc). |
It will, however that will take time. The first thing that's coming is ProtoInfo, JavaInfo and CcInfo in Starlark (most likely in this order). I tried different migration paths, and the easiest migration from "builtin Starlark code" to "pure Starlark code in repos" seems to be first force users to use @rules_proto, @rules_java and @rules_cc. It makes it possible to have some deps on providers still in Bazel. |
2bb4ed3
to
5b949a6
Compare
5b949a6
to
d84a216
Compare
d84a216
to
cbd6873
Compare
No description provided.