Mark gcc as gcc instead of compiler in Unix CC toolchain
#16297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
gcc as gcc instead of compiler in Unix CC toolchaingcc instead of compiler in Unix CC toolchain
fmeum
force-pushed
the
12707-detect-gcc
branch
5 times, most recently
from
363d121
to
a943d9e
Compare
This makes it possible to detect `gcc` specifically via a `config_setting` for the `@bazel_tools//tools/cpp:compiler` flag with value `gcc`. RELNOTES: The `@bazel_tools//tools/cpp:compiler` flag now has the value `gcc` if the configured compiler is detected to be gcc rather than the generic value `compiler`. A branch for `gcc` may have to be added to `select` statements that do not have a default case that handles gcc appropriately.
fmeum
force-pushed
the
12707-detect-gcc
branch
from
a943d9e
to
7dbc590
Compare
|
@oquenchil Would you be available to review this? |
buildbreaker2021
approved these changes
Sep 19, 2022
buildbreaker2021
added
the
awaiting-PR-merge
keith
reviewed
Sep 19, 2022
| } | ||
|
|
||
| function test_compiler_flag_clang() { | ||
| # TODO: The default toolchain always uses XCode's clang, but sets the compiler name to the generic |
There was a problem hiding this comment.
If you force using the C++ only toolchain on macOS this would likely pass, although maybe it still shouldn't
There was a problem hiding this comment.
I briefly went over the control flow and it seemed as if the fallback to the Unix toolchain would only be picked if Xcode couldn't be find. I have a follow-up PR where I will dig deeper into the macOS case.
sgowroji
removed
the
awaiting-PR-merge
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
This makes it possible to detect gcc specifically via a `config_setting` for the `@bazel_tools//tools/cpp:compiler` flag with value `gcc`. RELNOTES: The `@bazel_tools//tools/cpp:compiler` flag now has the value `gcc` if the configured compiler is detected to be gcc rather than the generic value `compiler`. A branch for `gcc` may have to be added to `select` statements that do not have a default case that handles gcc appropriately. Fixes bazelbuild#12707 Closes bazelbuild#16297. PiperOrigin-RevId: 475467838 Change-Id: I9fa98ddd3c7f29742357596280dfc98c939f0253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to detect gcc specifically via a
config_settingfor the@bazel_tools//tools/cpp:compilerflag with valuegcc.RELNOTES: The
@bazel_tools//tools/cpp:compilerflag now has the valuegccif the configured compiler is detected to be gcc rather than the generic valuecompiler. A branch forgccmay have to be added toselectstatements that do not have a default case that handles gcc appropriately.Fixes #12707