Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable --experimental_allow_unresolved_symlinks by default. #16458

Closed
wants to merge 1 commit into from
Closed

Enable --experimental_allow_unresolved_symlinks by default. #16458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ public OutputDirectoryNamingSchemeConverter() {

@Option(
name = "experimental_allow_unresolved_symlinks",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making this the old name and using just allow_unresolved_symlinks as the new name? Having to disable a default option via a flag called experimental could be confusing for users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the flag will stick around or whether people should actively toggle it; if it doesn't stick around then we should keep the experimental_ prefix.

And I am not the person to make that call - I am just doing the bare minimum to enable this in Bazel 6.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realistically, I don't think we will flip this flag at Google anytime soon so I guess it'll have to stay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the question is more whether we want people (both internally and externally) to change their default value. If not, let's keep the prefix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was scratching my head as to how to decide that. Your line of reasoning is quite nice, so I guess let's keep it?

defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {
OptionEffectTag.LOSES_INCREMENTAL_STATE,
Expand Down