Use an in-memory filesystem to track injected remote files #16477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of using Map. This allows implementing more fs operations later.
sgowroji
added
team-Remote-Exec
tjgq
approved these changes
Oct 17, 2022
| } | ||
| } | ||
|
|
||
| static class RemoteFileInfo extends FileInfo { |
There was a problem hiding this comment.
Will it be possible to reuse InMemoryFileInfo once we get rid of actionId (as we discussed elsewhere)?
There was a problem hiding this comment.
No:
- we have to override
getFastDigest()to return the digest of remote file. - we want to block operations that don't make sense to remote files e.g.
getOutputStream.
src/main/java/com/google/devtools/build/lib/remote/RemoteActionFileSystem.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java
Outdated
Show resolved
Hide resolved
coeuvre
force-pushed
the
inmemory-remote-fs
branch
from
53045c6 to
45aa131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using Map. This allows implementing more fs operations later.