Make bazel run works with minimal mode
#16545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreeM01
added
team-Remote-Exec
coeuvre
commented
Oct 26, 2022
| boolean useToplevelDownloader = remoteOutputsMode.downloadToplevelOutputsOnly(); | ||
|
|
||
| // Download toplevel artifacts for `run` command. | ||
| if ("run".equals(env.getCommandName())) { |
There was a problem hiding this comment.
We might need to support other commands (e.g. coverage, mobile-install, etc.). Do you think whether it is better if we always use toplevel downloader but pass in the download mode, let the downloaders decide what to download in both minimal/toplevel mode?
There was a problem hiding this comment.
Yeah, it does seem better to keep all of that logic in the downloader.
tjgq
approved these changes
Nov 7, 2022
| boolean useToplevelDownloader = remoteOutputsMode.downloadToplevelOutputsOnly(); | ||
|
|
||
| // Download toplevel artifacts for `run` command. | ||
| if ("run".equals(env.getCommandName())) { |
There was a problem hiding this comment.
Yeah, it does seem better to keep all of that logic in the downloader.
| @@ -306,6 +306,14 @@ public BlazeCommandResult exec(CommandEnvironment env, OptionsParsingResult opti | |||
| return BlazeCommandResult.detailedExitCode(result.getDetailedExitCode()); | |||
| } | |||
|
|
|||
| if (env.getOutputService() != null) { | |||
There was a problem hiding this comment.
Add a comment here explaining why this is necessary (since a casual reader of RunCommand.java might not be familiar with BwoB).
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Nov 22, 2022
Always use `ToplevelArtifactsDownloader` when building without the bytes. It checks the combination of current command (e.g. `build`, `run`, etc.) and download mode (e.g. `toplevel`, `minimal`) to decide whether download outputs for the toplevel targets or not. Also in the `RunCommand`, we wait for the background downloads before checking the local filesystem. Fixes bazelbuild#11920. Closes bazelbuild#16545. PiperOrigin-RevId: 487181884 Change-Id: I6b1a78a0d032d2cac8093eecf9c4d2e76f90380f
ShreeM01
pushed a commit
that referenced
this pull request
Nov 22, 2022
Always use `ToplevelArtifactsDownloader` when building without the bytes. It checks the combination of current command (e.g. `build`, `run`, etc.) and download mode (e.g. `toplevel`, `minimal`) to decide whether download outputs for the toplevel targets or not. Also in the `RunCommand`, we wait for the background downloads before checking the local filesystem. Fixes #11920. Closes #16545. PiperOrigin-RevId: 487181884 Change-Id: I6b1a78a0d032d2cac8093eecf9c4d2e76f90380f
meteorcloudy
removed
the
potential release blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use
ToplevelArtifactsDownloaderwhen building without the bytes.It checks the combination of current command (e.g.
build,run, etc.) and download mode (e.g.toplevel,minimal) to decide whether download outputs for the toplevel targets or not.Also in the
RunCommand, we wait for the background downloads before checking the local filesystem.Fixes #11920.