Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote/downloader] Don't include headers in FetchBlobRequest #16595

Closed
wants to merge 1 commit into from

Commits on Oct 27, 2022

  1. [remote/downloader] Don't include headers in FetchBlobRequest

    Including the headers in the request is very inefficient as credentials
    should never change the content of the downloaded archive. In fact,
    given that Bazel verifies the checksum of the downloaded file, the
    credentials cannot possibly used in a way where they influence
    the outcome of the download (other than deciding whether or not
    the user is allowed to download the blob at all). Hence, the
    credentials should not be included in the request.
    
    Users that need to send credentials to the remote downloader should
    do so by passing the credentials as metadata to the gRPC call.
    
    Note that the remote downloader is behind an experimental flag,
    so this change does not need to go thorugh the incompatible change
    process.
    Yannic committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e5a7389 View commit details
    Browse the repository at this point in the history