Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remote] Respect whether the server supports action cache updates #16624

Closed

Commits on Nov 1, 2022

  1. [remote] Respect whether the server supports action cache updates

    Only a subset of users may be allowed to update the action cache
    (e.g., only CI but not devs).
    
    Today, there are 2 ways to achive the desired behavior:
      - `GetCapabilities` returning that all users are allowed to update,
        and `UpdateActionResult` returning an error that Bazel prints and
        ignores, or
      - have the users that are not allowed to update the action cache
        set `--remote_upload_local_results=false`.
    
    Why don't we instead respect whether the remote cache supports
    uploading action results?
    
    Note that this requires support from the remote system to fully work
    (i.e., it needs to return `update_enabled = false` for users that
    don't have permission). Otherwise, Bazel's behavior will be the
    same as before this change: failed `UpdateActionResult` do not cause
    the build to fail. The only change this introduces is that Bazel
    will no longer error if `--remote_upload_local_results=true`
    and `GetCapabilities` returning `update_enabled = false`.
    Yannic committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b3cb165 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge remote-tracking branch 'upstream/master' into yannic-remotecach…

    …e-respect-server-caps
    Yannic committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    946b193 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c13e551 View commit details
    Browse the repository at this point in the history
  3. add warning

    Yannic committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    dedfae0 View commit details
    Browse the repository at this point in the history
  4. fix some tests

    Yannic committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3fa1c8c View commit details
    Browse the repository at this point in the history
  5. verify internal state

    Yannic committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d63c5c8 View commit details
    Browse the repository at this point in the history
  6. Revert "verify internal state"

    This reverts commit d63c5c8.
    Yannic committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    fd7346d View commit details
    Browse the repository at this point in the history