[6.0.0] [remote/downloader] Don't include headers in FetchBlobRequest
#16677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the headers in the request is very inefficient as credentials should never change the content of the downloaded archive. In fact, given that Bazel verifies the checksum of the downloaded file, the credentials cannot possibly used in a way where they influence the outcome of the download (other than deciding whether or not the user is allowed to download the blob at all). Hence, the credentials should not be included in the request. Users that need to send credentials to the remote downloader should do so by passing the credentials as metadata to the gRPC call. Note that the remote downloader is behind an experimental flag, so this change does not need to go thorugh the incompatible change process. Closes bazelbuild#16595. PiperOrigin-RevId: 485576157 Change-Id: I8afc7c818e4eed63ac1f70c3e4c2115a1d365830
|
cc @tjgq |
Yannic
changed the title
FetchBlobRequestFetchBlobRequest
ShreeM01
added
team-Remote-Exec
|
@meteorcloudy can you help getting this merged please? |
…b03a3b61f3af3a2c88f7ab7d
|
@tjgq Please LGTM if this looks good to be cherry-picked for 6.0 ;) |
tjgq
approved these changes
Nov 10, 2022
tjgq
added
awaiting-PR-merge
|
@Yannic Please also rebase this one so that it'll get merged ;) |
…b03a3b61f3af3a2c88f7ab7d
|
done |
sgowroji
removed
the
awaiting-PR-merge
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the headers in the request is very inefficient as credentials should never change the content of the downloaded archive. In fact, given that Bazel verifies the checksum of the downloaded file, the credentials cannot possibly used in a way where they influence the outcome of the download (other than deciding whether or not the user is allowed to download the blob at all). Hence, the credentials should not be included in the request.
Users that need to send credentials to the remote downloader should do so by passing the credentials as metadata to the gRPC call.
Note that the remote downloader is behind an experimental flag, so this change does not need to go thorugh the incompatible change process.
Closes #16595.
PiperOrigin-RevId: 485576157
Change-Id: I8afc7c818e4eed63ac1f70c3e4c2115a1d365830