-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _repo_mapping
in C++ runfiles library
#16701
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stacked on #16652, please ignore the first commit. |
18 tasks
fmeum
requested review from
lberki,
oquenchil,
Wyverald and
meteorcloudy
as code owners
November 8, 2022 20:24
ShreeM01
added
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Nov 8, 2022
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Nov 8, 2022
@bazel-io fork 6.0.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Nov 9, 2022
oquenchil
approved these changes
Nov 9, 2022
fmeum
force-pushed
the
16124-cc-repo-mapping
branch
from
November 9, 2022 17:51
fb29e95
to
542772d
Compare
I resolved the merge conflicts. |
Wyverald
approved these changes
Nov 9, 2022
Wyverald
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Nov 9, 2022
@Wyverald Keep in mind that this is still stacked on the |
fmeum
force-pushed
the
16124-cc-repo-mapping
branch
from
November 10, 2022 15:58
542772d
to
3169574
Compare
Rebased and no longer stacked. |
meteorcloudy
approved these changes
Nov 10, 2022
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 11, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16701. PiperOrigin-RevId: 487806351 Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 11, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16701. PiperOrigin-RevId: 487806351 Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 13, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16701. PiperOrigin-RevId: 487806351 Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 13, 2022
Work towards bazelbuild#16124 Closes bazelbuild#16701. PiperOrigin-RevId: 487806351 Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
sgowroji
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #16124