Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _repo_mapping in C++ runfiles library #16701

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 8, 2022

Work towards #16124

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

Stacked on #16652, please ignore the first commit.

@fmeum fmeum marked this pull request as ready for review November 8, 2022 20:24
@ShreeM01 ShreeM01 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Nov 8, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2022
@lberki lberki removed their request for review November 9, 2022 08:16
@meteorcloudy
Copy link
Member

@bazel-io fork 6.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 9, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 9, 2022

I resolved the merge conflicts.

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 9, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 9, 2022

@Wyverald Keep in mind that this is still stacked on the _repo_mapping PR, which should probably be merged separately.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 10, 2022

Rebased and no longer stacked.

@fmeum fmeum deleted the 16124-cc-repo-mapping branch November 11, 2022 22:58
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 11, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16701.

PiperOrigin-RevId: 487806351
Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 11, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16701.

PiperOrigin-RevId: 487806351
Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 13, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16701.

PiperOrigin-RevId: 487806351
Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 13, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16701.

PiperOrigin-RevId: 487806351
Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 14, 2022
ShreeM01 pushed a commit that referenced this pull request Nov 14, 2022
Work towards #16124

Closes #16701.

PiperOrigin-RevId: 487806351
Change-Id: I3b04fef84d817b0875bfd71c65efe6db13468b13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants