Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4.0] Keep credentials cached across build commands. #16884

Merged
merged 1 commit into from
Nov 29, 2022
Merged

[5.4.0] Keep credentials cached across build commands. #16884

merged 1 commit into from
Nov 29, 2022

Commits on Nov 29, 2022

  1. [5.4.0] Keep credentials cached across build commands. 

    When using a credential helper, the lifetime of the credential cache is currently tied to an individual command, which causes the helper to be called for every command resulting in poor incremental build latency for builds using a non-trivial helper.

Since the cache must be shared by RemoteModule and BazelBuildServiceModule, I've introduced a new CredentialModule whose sole purpose is to provide access to it.

Closes bazelbuild#16822.

PiperOrigin-RevId: 491598103
Change-Id: Ib668954b635a0e9498f0a7418707d6a2dfae0265
    @tjgq
    tjgq committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    aa4fe8d View commit details
    Browse the repository at this point in the history