-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental cc_static_library
rule
#16954
Conversation
fbcb331
to
a42ff75
Compare
0f9622b
to
f260501
Compare
799d1e8
to
dce3fe7
Compare
@fmeum Any update on my comments? |
@aminya and @fmeum any updates on the status / timeline for this? We (as in, my company) are considering moving off Bazel partially or completely and lack of transitive static libraries is one of the major factors in making such decisions. We need to understand our timeline and resource allocation should be and that hinges on this MR + issue thread. |
Sorry for the lack of response, other efforts kept needing priority over the one. I'm planning to get back to it in April. @Algomorph If you really just want to build transitive static libraries, then you could really use any of the Starlark rules proposed on the original issue without being blocked on me. Do you have any special requirements that only my design would address? |
@fmeum thanks for getting back to me so promptly and sharing the plan. April will probably work for us. I got the general sense from reading through the thread that people are running into issues with the proposed rules, but granted, I haven't personally tried any of them yet. We will review further at our next planning session and reevaluate, perhaps even assist -- if we can allocate the resources for it. |
Unfortunately, one of my dependencies uses Bazel, and I am stuck in the walled garden of Bazel without a way out. Having static libraries is the only way that allows us to build the dependency in isolation and use it in other projects without the fragile and bulky alternative of whole archive shared libraries.
I tried all the proposed rules, and only this PR seems to partially work for me except for the errors I mentioned here
|
836e4df
to
af7c5ce
Compare
af7c5ce
to
5313d07
Compare
54957f9
to
060d15c
Compare
@bazel-io fork 7.3.0 |
@fmeum Please add docstring in |
@iancha1992 Done. Despite the |
@comius WDYT? The internal CL is still blocked because of it. |
I added a doc string, do I need to do anything else to unblock it? |
@iancha1992 Should be fixed now, could you run the linter again? |
@bazel-io fork 7.4.0 |
I think also adding a docstring at the first statement of the file is needed. This will do. @fmeum |
@iancha1992 Added! |
RELNOTES: The new `cc_static_library` rule produces a static library that bundles given targets and all their transitive dependencies. It has to be enabled via `--experimental_cc_static_library`. Implements https://docs.google.com/document/d/1jN0LUmp6_-rV9_f-Chx-Cs6t_5iOm3fziOklzBGjGIg/edit Fixes bazelbuild#1920 Closes bazelbuild#16954. PiperOrigin-RevId: 661382285 Change-Id: I972afd1a38d50ab4e48d9b3c189f1662b0096bbf
RELNOTES: The new `cc_static_library` rule produces a static library that bundles given targets and all their transitive dependencies. It has to be enabled via `--experimental_cc_static_library`. Implements https://docs.google.com/document/d/1jN0LUmp6_-rV9_f-Chx-Cs6t_5iOm3fziOklzBGjGIg/edit Fixes #1920 Closes #16954. PiperOrigin-RevId: 661382285 Change-Id: I972afd1a38d50ab4e48d9b3c189f1662b0096bbf Closes #23192
RELNOTES: The new
cc_static_library
rule produces a static library that bundles given targets and all their transitive dependencies. It has to be enabled via--experimental_cc_static_library
.Implements https://docs.google.com/document/d/1jN0LUmp6_-rV9_f-Chx-Cs6t_5iOm3fziOklzBGjGIg/edit
Fixes #1920