Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runfiles creation with MANIFEST when building without the bytes #16972

Closed
wants to merge 4 commits into from
Closed

Fix runfiles creation with MANIFEST when building without the bytes #16972

wants to merge 4 commits into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Dec 9, 2022

Fixes #16955.

@coeuvre coeuvre requested a review from a team as a code owner December 9, 2022 13:20
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Dec 9, 2022
@coeuvre coeuvre requested a review from tjgq December 9, 2022 13:58
@coeuvre
Copy link
Member Author

coeuvre commented Dec 9, 2022

@tjgq I updated the code after imported it internally to fix internal tests. Please review CL directly when you are on it!

Wyverald pushed a commit that referenced this pull request Dec 12, 2022
@coeuvre @Wyverald
Fix runfiles creation with MANIFEST when building without the bytes
e7be7a6 
`getLastModifiedTime` and `setLastModifiedTime` are used by `FileSystemUtils.copyFile` to copy files. When runfiles is disabled, `SymlinkTreeStrategy#createSymlinks` use it to copy MANIFEST file.

Fixes #16955.

Closes #16972.

PiperOrigin-RevId: 494712456
Change-Id: I9a77063f35e1f6e2559c02612790542e996994b8
@Wyverald Wyverald mentioned this pull request Dec 12, 2022
Merged
Wyverald added a commit that referenced this pull request Dec 12, 2022
@Wyverald @coeuvre
Fix runfiles creation with MANIFEST when building without the bytes (#…
7e80d02 
…16993)

`getLastModifiedTime` and `setLastModifiedTime` are used by `FileSystemUtils.copyFile` to copy files. When runfiles is disabled, `SymlinkTreeStrategy#createSymlinks` use it to copy MANIFEST file.

Fixes #16955.

Closes #16972.

PiperOrigin-RevId: 494712456
Change-Id: I9a77063f35e1f6e2559c02612790542e996994b8

Co-authored-by: Chi Wang <chiwang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq Awaiting requested review from tjgq

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runfiles tree creation fails on Windows
2 participants
@coeuvre @sgowroji