Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undeclared test outputs after zipping on Windows #17003

Closed
wants to merge 2 commits into from
Closed

Remove undeclared test outputs after zipping on Windows #17003

wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 13, 2022

No description provided.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 13, 2022

Stacked on #16973

@fmeum fmeum force-pushed the remove-undeclared-outputs-windows branch 5 times, most recently from 743e71f to 00fe493 Compare December 13, 2022 08:31
@fmeum fmeum marked this pull request as ready for review December 13, 2022 08:57
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 13, 2022

@tjgq Could you review?

@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Dec 13, 2022
@fmeum fmeum force-pushed the remove-undeclared-outputs-windows branch from 00fe493 to 27416a2 Compare December 13, 2022 09:40
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 13, 2022

No longer stacked.

tjgq
tjgq requested changes Dec 13, 2022
View reviewed changes
tools/test/windows/tw.cc Outdated Show resolved Hide resolved
@fmeum fmeum force-pushed the remove-undeclared-outputs-windows branch from 27416a2 to 5f1696e Compare December 13, 2022 11:45
@fmeum fmeum force-pushed the remove-undeclared-outputs-windows branch from 5f1696e to 1cd4a57 Compare December 13, 2022 13:11
@fmeum fmeum requested a review from tjgq December 13, 2022 13:28
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 13, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 14, 2022
@fmeum fmeum deleted the remove-undeclared-outputs-windows branch December 14, 2022 07:06
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@fmeum @hvadehra
Remove undeclared test outputs after zipping on Windows
6e31e82 
Closes #17003.

PiperOrigin-RevId: 495040806
Change-Id: I8cc836d0bc8ad291b39cf4293c4b1f15254e5d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @tjgq @sgowroji