Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1.0]Use long executable path instead of argv[0] in all launchers #17272

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[6.1.0]Use long executable path instead of argv[0] in all launchers #17272

merged 3 commits into from
Jan 20, 2023

Commits on Jan 19, 2023

  1. Use long executable path instead of argv[0] in all launchers 

    `argv[0]` can differ from the path of the launcher executable. The latter can contain 8.3 style filenames, which need to be resolved to long paths before path manipulation (e.g. appending ".runfiles") can succeed.

The Python launcher handled this correctly, but other launchers didn't use the long executable path consistently.

Closes #16916.

PiperOrigin-RevId: 493615543
Change-Id: Ic8161890181c0110ecdf6893b9835e6f99d01097
    @fmeum @ShreeM01
    fmeum authored and ShreeM01 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    4a7169b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Merge branch 'release-6.1.0' into ks/cherry-pick16916

    @meteorcloudy
    meteorcloudy authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    97a74c1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.1.0' into ks/cherry-pick16916

    @ShreeM01
    ShreeM01 authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    454e434 View commit details
    Browse the repository at this point in the history