Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPATHs for cc toolchain solib when sibling layout is used #17276

Closed
wants to merge 5 commits into from
Closed

Fix RPATHs for cc toolchain solib when sibling layout is used #17276

wants to merge 5 commits into from

Commits on Jan 20, 2023

  1. Refactor logics to find runtime library search directories

    * Extracts logic to find execroots as a separate method and moves it into the `collectLibrariesToLink()` method from the constructor.
    * Extracts logic to create rpaths for toolchain libraries as a separate method.
    * Reorganizes the logic for better readability.
    
    This debloats the constructor and makes further changes easier.
    yuzhy8701 committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    2cfda71 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Correctly compute RPATHs for toolchain solib.

    When sibling repository layout is used, the toolchain solib directory is not co-located with the main solib (solib_<cpu>). Therefore, the RPATHs for toolchain solib need to be computed separately, in a similar manner as how they are computed for the main solib.
    
    This change uses a private implementation of `getRelative()` function, rather than the `PathFragment.relativeTo()` method. The reason is that `PathFragment.relativeTo()` requires the base path to be a prefix which is not true in the cases here.
    
    Fixes #16956
    yuzhy8701 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    da9ef5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e29951 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Configuration menu
    Copy the full SHA
    4da300e View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Configuration menu
    Copy the full SHA
    b45bcd1 View commit details
    Browse the repository at this point in the history