Prepare backwards compatible usage of optional C++ toolchain #17308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding an alias and a no-op keyword argument now, rulesets can start using the new optional form of `find_cpp_toolchain` now and benefit from the toolchain actually being optional once that has been implemented in a future version of Bazel.
fmeum
changed the title
katre
approved these changes
Jan 24, 2023
|
I'll let @oquenchil review and approve before merging, but this looks good. |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
added
team-Rules-CPP
oquenchil
approved these changes
Jan 25, 2023
oquenchil
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 26, 2023
By adding an alias and a no-op keyword argument now, rulesets can start using the new optional form of `find_cpp_toolchain` now and benefit from the toolchain actually being optional once that has been implemented in a future version of Bazel. Work towards #16966 Closes #17308. PiperOrigin-RevId: 504501621 Change-Id: I549fea6290195aadad4ccbd045c0aa3c180946d2 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
By adding an alias and a no-op keyword argument now, rulesets can start using the new optional form of `find_cpp_toolchain` now and benefit from the toolchain actually being optional once that has been implemented in a future version of Bazel. Work towards #16966 Closes #17308. PiperOrigin-RevId: 504501621 Change-Id: I549fea6290195aadad4ccbd045c0aa3c180946d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding an alias and a no-op keyword argument now, rulesets can start using the new optional form of
find_cpp_toolchainnow and benefit from the toolchain actually being optional once that has been implemented in a future version of Bazel.Work towards #16966