Fix worker and multiplex workers for DexBuilder and Desugar actions #17351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Android
Bencodes
force-pushed
the
add-asserts-to-test_persistent_multiplex_desugaring
branch
from
b0426f4
to
16379d7
Compare
Bencodes
force-pushed
the
add-asserts-to-test_persistent_multiplex_desugaring
branch
from
16379d7
to
939a81d
Compare
Bencodes
changed the title
Bencodes
force-pushed
the
add-asserts-to-test_persistent_multiplex_desugaring
branch
2 times, most recently
from
ff9594e
to
0ef0089
Compare
Bencodes
force-pushed
the
add-asserts-to-test_persistent_multiplex_desugaring
branch
from
0ef0089
to
03bfcbb
Compare
ted-xie
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Only one minor nit that we can fix internally: there's a comment alluding to the new-deleted flag use_workers_with_bexbuilder at https://github.com/bazelbuild/bazel/blob/master/tools/android/BUILD.tools#L51 that we'll want to delete. Otherwise LGTM. Thanks, Ben!
ted-xie
added
awaiting-PR-merge
|
Opened up a cherry pick here for when this lands in master #17965 |
ted-xie
requested changes
Apr 4, 2023
src/main/java/com/google/devtools/build/lib/rules/android/AndroidConfiguration.java
Show resolved
Hide resolved
ted-xie
added
awaiting-user-response
ted-xie
approved these changes
Apr 6, 2023
Bencodes
deleted the
add-asserts-to-test_persistent_multiplex_desugaring
branch
|
@bazel-io fork 6.2.0 |
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Fixing up the DexBuilder and Desugar actions so that they correctly spawn worker or multiplexed worker actions. `--modify_execution_info` doesn't work as expected and is not additive, which results in the previous execution infos being removed. Closes bazelbuild#17351. PiperOrigin-RevId: 523696356 Change-Id: Iada7fb75df5b4d2e3ba1308110977899567f2bc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up the DexBuilder and Desugar actions so that they correctly spawn worker or multiplexed worker actions.
--modify_execution_infodoesn't work as expected and is not additive, which results in the previous execution infos being removed.