[6.1.0]Do not recommend shallow_since for git_repository
#17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git's `--shallow-since` feature can lead to broken checkouts and a fix isn't likely to happen: https://public-inbox.org/git/CAPSG9dZV2EPpVKkOMcjv5z+NF7rUu=V-ZkZNx47rCv122HsiKg@mail.gmail.com/T/#u This commit removes `shallow_since` from the canonical reproducible form of `git_repository` unless the attribute is provided explicitly. In cases where Bazel's attempt at fetching with `--depth=1` fail, e.g. if there is no server support for shallow fetches of arbitrary commits, the progress message is now used to inform the user about this potential for fetch time optimizations. Fixes #10292 Fixes #12857 Closes #17356. PiperOrigin-RevId: 508569071 Change-Id: I01e6662e38c236d1800d427f66d48a05df818800
sgowroji
added
team-OSS
Wyverald
approved these changes
Feb 15, 2023
primiano
pushed a commit
to google/perfetto
that referenced
this pull request
Apr 17, 2023
…nterproductive Historically, shallow_since was supposed to help avoid a full repository clone when only a single commit is necessary (apparently it's not as simple as clone --depth=1 for commits that aren't a branch or a tag). But the option has known edge cases and is now discouraged: bazelbuild/bazel#17465. Further, as far as I can tell individual-commit fetches are properly supported under v2 git protocol. I can't figure out how to properly trace the git commands that bazel issues, but a manual v2 fetch against the AOSP gerrit succeeded (per GIT_TRACE_PACKET), so I hope that bazel will end up on v2 as well. So my plan is to submit this and see if CI fetch flakes go away. If not or we see evidence of full-repo clone fallback kicking in, I'll investigate further. Change-Id: I9d6fc5f373a84fdc434b841dbc0575fe3123dd5b
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git's
--shallow-sincefeature can lead to broken checkouts and a fix isn't likely to happen: https://public-inbox.org/git/CAPSG9dZV2EPpVKkOMcjv5z+NF7rUu=V-ZkZNx47rCv122HsiKg@mail.gmail.com/T/#uThis commit removes
shallow_sincefrom the canonical reproducible form ofgit_repositoryunless the attribute is provided explicitly. In cases where Bazel's attempt at fetching with--depth=1fail, e.g. if there is no server support for shallow fetches of arbitrary commits, the progress message is now used to inform the user about this potential for fetch time optimizations.Fixes #10292
Fixes #12857
Closes #17356.
PiperOrigin-RevId: 508569071
Change-Id: I01e6662e38c236d1800d427f66d48a05df818800