Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bazel 6.0 crash regression #17590

Closed
wants to merge 1 commit into from
Closed

Fix Bazel 6.0 crash regression #17590

wants to merge 1 commit into from

Conversation

gregestren
Copy link
Contributor

Stop crashes when incompatible target skipping mixes with ---auto_cpu_environment_group.

Fixes #17561.

PiperOrigin-RevId: 512125121
Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51

@gregestren
Fix Bazel 6.0 crash regression.
558ea80 
Stop crashes when incompatible target skipping mixes with
---auto_cpu_environment_group.

Fixes bazelbuild#17561.

PiperOrigin-RevId: 512125121
Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51
aranguyen
aranguyen approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@aranguyen aranguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aranguyen aranguyen added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 24, 2023
@gregestren gregestren added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Feb 24, 2023
@drraghavendra
Copy link

drraghavendra commented Feb 26, 2023 •
edited
Loading

Log spew appeared while the crash of Bazel on Mac Os happens

FATAL: bazel crashed due to an internal error. Printing stack trace:
com.google.common.base.VerifyException: expected a non-null reference
at com.google.common.base.Verify.verifyNotNull(Verify.java:503)
at com.google.common.base.Verify.verifyNotNull(Verify.java:479)
at com.google.devtools.build.lib.analysis.constraints.TopLevelConstraintSemantics.getMissingEnvironments(TopLevelConstraintSemantics.java:493)
at com.google.devtools.build.lib.analysis.constraints.TopLevelConstraintSemantics.compatibilityWithTargetEnvironment(TopLevelConstraintSemantics.java:213)
at com.google.devtools.build.lib.analysis.constraints.TopLevelConstraintSemantics.checkTargetEnvironmentRestrictions(TopLevelConstraintSemantics.java:376)
at com.google.devtools.build.lib.analysis.BuildView.update(BuildView.java:492)
at com.google.devtools.build.lib.buildtool.AnalysisPhaseRunner.runAnalysisPhase(AnalysisPhaseRunner.java:233)
at com.google.devtools.build.lib.buildtool.AnalysisPhaseRunner.execute(AnalysisPhaseRunner.java:139)
at com.google.devtools.build.lib.buildtool.BuildTool.buildTargets(BuildTool.java:180)
at com.google.devtools.build.lib.buildtool.BuildTool.processRequest(BuildTool.java:494)
at com.google.devtools.build.lib.buildtool.BuildTool.processRequest(BuildTool.java:462)
at com.google.devtools.build.lib.runtime.commands.BuildCommand.exec(BuildCommand.java:103)
at com.google.devtools.build.lib.runtime.BlazeCommandDispatcher.execExclusively(BlazeCommandDispatcher.java:608)
at com.google.devtools.build.lib.runtime.BlazeCommandDispatcher.exec(BlazeCommandDispatcher.java:233)
at com.google.devtools.build.lib.server.GrpcServerImpl.executeCommand(GrpcServerImpl.java:550)
at com.google.devtools.build.lib.server.GrpcServerImpl.lambda$run$1(GrpcServerImpl.java:614)
at io.grpc.Context$1.run(Context.java:566)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source) java.lang

@gregestren
Copy link
Contributor Author

@drraghavendra are you clarifying the original error or saying that it still happens even with this fix?

@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 28, 2023
@keertk keertk mentioned this pull request Feb 28, 2023
Merged
meteorcloudy pushed a commit that referenced this pull request Feb 28, 2023
@keertk @gregestren
Fix Bazel 6.0 crash regression (#17613)
546e9e2 
Stop crashes when incompatible target skipping mixes with ---auto_cpu_environment_group.

Fixes #17561.

PiperOrigin-RevId: 512125121
Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51

Closes #17590.

Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51
PiperOrigin-RevId: 512820070

Co-authored-by: Googler <gregce@google.com>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@gregestren @fweikert
Fix Bazel 6.0 crash regression
ca9cd60 
Stop crashes when incompatible target skipping mixes with ---auto_cpu_environment_group.

Fixes bazelbuild#17561.

PiperOrigin-RevId: 512125121
Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51

Closes bazelbuild#17590.

Change-Id: If5960a6abb08f8fe4f2643af6249c8528b7a2c51
PiperOrigin-RevId: 512820070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranguyen aranguyen aranguyen approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[6.0 regression] Crash on macOS ARM64 when using target_compatible_with = ["@platforms//:incompatible"]
4 participants
@gregestren @drraghavendra @aranguyen @sgowroji