Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax JSON parser, ensure duplicate keys are overridden #17645

Closed
wants to merge 2 commits into from
Closed

Relax JSON parser, ensure duplicate keys are overridden #17645

wants to merge 2 commits into from

Conversation

LavaToaster
Copy link
Contributor

Resolves #15605

@ShreeM01 ShreeM01 added team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel awaiting-review PR is awaiting review from an assigned reviewer labels Mar 2, 2023
@tetromino
Update Json.java
a2402b2 
Update json.decode doc string
tetromino
tetromino approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@tetromino tetromino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I took the liberty of fixing the json.decode doc string to match the new behavior.

@copybara-service copybara-service bot closed this in 8548e20 Mar 6, 2023
@LavaToaster LavaToaster deleted the issue/15605-relax-json-parser branch March 7, 2023 10:14
ShreeM01 pushed a commit that referenced this pull request Mar 23, 2023
@tetromino @LavaToaster
Relax JSON parser, ensure duplicate keys are overridden (#17868)
dee2ac0 
Resolves #15605

Closes #17645.

PiperOrigin-RevId: 514491743
Change-Id: I17ea9fb57682b668bff02bc64fefd75edb2cf2ee

Co-authored-by: Adam Lavin <adam@lavoaster.co.uk>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@LavaToaster @fweikert
Relax JSON parser, ensure duplicate keys are overridden
13cd115 
Resolves bazelbuild#15605

Closes bazelbuild#17645.

PiperOrigin-RevId: 514491743
Change-Id: I17ea9fb57682b668bff02bc64fefd75edb2cf2ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetromino tetromino tetromino approved these changes

@brandjon brandjon Awaiting requested review from brandjon brandjon is a code owner

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Starlark-Interpreter Issues involving the Starlark interpreter used by Bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json.decode is too strict; fails on duplicate keys
3 participants
@LavaToaster @tetromino @ShreeM01