Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2.0]Update java_tools v11.12 #17717

Closed
wants to merge 3 commits into from
Closed

[6.2.0]Update java_tools v11.12 #17717

wants to merge 3 commits into from

Conversation

ShreeM01
Copy link
Contributor

@ShreeM01 ShreeM01 commented Mar 9, 2023

Release tracking issue: bazelbuild/java_tools#64

Closes #17642.

PiperOrigin-RevId: 513763909
Change-Id: I197d05c9b72a79bdcb62716027ee5d87335fba88

tjgq and others added 2 commits March 9, 2023 09:09
While non-empty tree artifacts in the inputs to an action are expanded into the files they contain and omitted from the input mapping, empty tree artifacts are still present, as they signal the need to create the directory.

I'm explicitly skipping the empty tree artifacts in prefetchFiles() as otherwise they get skipped as a result of FileArtifactValue#isRemote() returning false for the FileArtifactValue associated with an empty tree artifact (even if it was produced remotely!), which is extremely subtle.

Closes #17183.

[NOTE: this is a combined cherry pick of 763f966 and 4c57def, as the former left Bazel in a broken state.]

PiperOrigin-RevId: 501207095
Change-Id: Ib52727d6fdc6b7a291a61fba33914e57531fb1f4
Release tracking issue: bazelbuild/java_tools#64

Closes #17642.

PiperOrigin-RevId: 513763909
Change-Id: I197d05c9b72a79bdcb62716027ee5d87335fba88
@ShreeM01 ShreeM01 deleted the branch bazelbuild:release-6.2.0 March 9, 2023 21:44
@ShreeM01 ShreeM01 closed this Mar 9, 2023
@ShreeM01 ShreeM01 reopened this Mar 9, 2023
@ShreeM01 ShreeM01 closed this by deleting the head repository Mar 9, 2023
@ShreeM01 ShreeM01 reopened this Mar 9, 2023
@sgowroji sgowroji added the team-Rules-Java Issues for Java rules label Mar 10, 2023
@ShreeM01 ShreeM01 closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants