Avoid unnecessary copying when building Merkle trees. #17912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
merkle-copying
branch
4 times, most recently
from
a8d844b
to
0a1e8bc
Compare
Instead of accumulating a single set of children in DirectoryTreeBuilder and later splitting it up into file, symlink and subdirectory sets, we can accumulate the latter directly.
github-actions
bot
added
awaiting-review
coeuvre
approved these changes
Mar 29, 2023
coeuvre
added
awaiting-PR-merge
|
@bazel-io flag |
|
@bazel-io fork 6.2.0 |
sgowroji
removed
the
awaiting-PR-merge
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 30, 2023
Instead of accumulating a single set of children in DirectoryTreeBuilder and later splitting it up into file, symlink and subdirectory sets, we can accumulate the latter directly. Closes bazelbuild#17912. PiperOrigin-RevId: 520585350 Change-Id: I02b26825976c72d59462a66ffd9afaec3d7c4176
ShreeM01
added a commit
that referenced
this pull request
Mar 31, 2023
* Avoid unnecessary copying when building Merkle trees. Instead of accumulating a single set of children in DirectoryTreeBuilder and later splitting it up into file, symlink and subdirectory sets, we can accumulate the latter directly. Closes #17912. PiperOrigin-RevId: 520585350 Change-Id: I02b26825976c72d59462a66ffd9afaec3d7c4176 * Update DirectoryTree.java * Update DirectoryTree.java --------- Co-authored-by: Tiago Quelhas <tjgq@google.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Instead of accumulating a single set of children in DirectoryTreeBuilder and later splitting it up into file, symlink and subdirectory sets, we can accumulate the latter directly. Closes bazelbuild#17912. PiperOrigin-RevId: 520585350 Change-Id: I02b26825976c72d59462a66ffd9afaec3d7c4176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of accumulating a single set of children in DirectoryTreeBuilder and later splitting it up into file, symlink and subdirectory sets, we can accumulate the latter directly.