Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff against a dedicated exec version of the baseline configuration #18002

Closed
wants to merge 2 commits into from
Closed

Diff against a dedicated exec version of the baseline configuration #18002

wants to merge 2 commits into from

Commits on Apr 13, 2023

  1. Move CoreOptions exec modifiations out of ExecutionTransitionFactory 

    Now that the host configuration is gone, fixed changes to the
`CoreOptions` when switching to the exec configuration are better
handled in `CoreOptions#getExec`.
    @fmeum
    fmeum committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    04be760 View commit details
    Browse the repository at this point in the history

  2. Diff against a dedicated exec version of the baseline configuration 

    When `--experimental_output_directory_naming_scheme` is set to
`diff_against_baseline`, the current configuration is diffed against a
baseline and a hash of the diff is appended to the output directory.

If a target that is built in the exec configuration transitions further,
the diff would, before this change, include the (substantial) set of
flags that differ between the top-level target and exec configuration.
This made caching less efficient across builds that change flags that
are reset by the exec configuration, e.g. `--collect_code_coverage`.

This is fixed by comparing exec configuration against a dedicated exec
version of the top-level target configuration, which is safe since
`is exec configuration` itself is explicit in the output path.
    @fmeum
    fmeum committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6bcc61a View commit details
    Browse the repository at this point in the history