[Bootstrap Template] Fixed bootstrap template not being passed to py_binary from py_runtime on bazel latest

[ankit-agarwal-ai]

This PR fixes a small bug where the bootstrap template runtime file was not being passed to Py Binary. This broke the bootstrap template feature on bazel latest authored in #16806

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ankit-agarwal-ai]

cc @rickeylev should be a relatively simple fix.

[rickeylev]

Ah that must have gotten lost when rewriting the java to starlark and a following refactor. Yeah, simple fix.

[Pavank1992]

@ankit-agarwal1999, as PR is awaiting to merge, could you please fix the above buildkite errors? Thanks!

[rickeylev]

It looks like just one test is failing because bootstrap template is None, which makes sense -- the test is specifically testing a manually created PyRuntimeInfo. It's expected that PyRuntimeInfo.bootstrap_template is set; Normally this is handled by the py_runtime rule, but the test is specifically checking for a custom implementation.

This is around the line you'll need to modify:
https://cs.opensource.google/bazel/bazel/+/master:src/test/java/com/google/devtools/build/lib/rules/python/PythonStarlarkApiTest.java;l=120;drc=17827eee79808fceb6558d632c5b5594e8e9a47a

The net changes should be something like:

• In the call to PyRuntimeInfo(), add bootstrap_template=ctx.file.bootstrap_template
• A couple lines below, to the userruntime rule definition, add 'bootstrap_template': attr.label_list(allow_files=True)
• A couple lines below, in the call to userruntime() add bootstrap_template='bootstrap.txt'

And bazel test //src/test/java/com/google/devtools/build/lib/rules/python:PythonStarlarkApiTest

[ankit-agarwal-ai]

Thanks for the help @rickeylev I think I was able to get it to work. The test passes when I run it locally.

[rickeylev]

@Pavank1992 tests are fixed