-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test path mapping in Bazel #18155
Test path mapping in Bazel #18155
Conversation
174a0e0
to
2d0e761
Compare
2d0e761
to
9850659
Compare
533efc8
to
e45173b
Compare
98bd6c7
to
f38db1e
Compare
CC @aranguyen |
src/main/java/com/google/devtools/build/lib/analysis/actions/CustomCommandLine.java
Outdated
Show resolved
Hide resolved
f38db1e
to
09d02eb
Compare
eedcd5f
to
d417ec5
Compare
471cbc8
to
73ec1ad
Compare
@fmeum Do we need this for bazelcon? |
It's just the combination of all the other required PRs + end-to-end tests. When the required PRs have been merged, we will probably want to merge the tests, but don't have to before BazelCon :-) |
`PathMapper`s rewrite paths in command lines to make them more cache friendly, which requires executor support to stage files at the rewritten paths. This commit wires up the `PathMapper` used by a given `Spawn` in `SpawnInputsExpander`, which takes care of this for inputs to `Spawn`s executed in a sandbox or remotely. Constructs specific to Blaze, filesets and archived tree artifacts, are not covered by this change. An end-to-end test will be added in #18155, but requires #19718, #19719, and #19721. Work towards #6526 Closes #19718. PiperOrigin-RevId: 571109361 Change-Id: Ia38464011f658178ab2a1981a3ddaf5aead7c8fa
73ec1ad
to
48af955
Compare
@gregestren Could you review this while Ara is OOO? It essentially consists of tests only, with one very minor change described in the PR description. Getting this merged would allow me to more effectively work on #19872 and get it in shape, including tests, before Ara is back. |
d56a922
to
c52b670
Compare
Sure, I'll take a look today. |
src/main/java/com/google/devtools/build/lib/rules/java/JavaCompileAction.java
Show resolved
Hide resolved
c52b670
to
406a2b7
Compare
@bazel-io flag |
@bazel-io fork 7.0.0 |
Add end-to-end tests to verify that `--experimental_output_paths=strip` works with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enable `config_stripped_outputs_test` for Bazel (e.g. make it work on macOS). This requires a minor changes: We ensure that full `.jdeps` are rewritten to contain unmapped paths even after a fallback to full classpath. Closes bazelbuild#18155. PiperOrigin-RevId: 582014351 Change-Id: If9c51acb090d9fc4bc86052143ad9960e44fd8a7
Add end-to-end tests to verify that `--experimental_output_paths=strip` works with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enable `config_stripped_outputs_test` for Bazel (e.g. make it work on macOS). This requires a minor changes: We ensure that full `.jdeps` are rewritten to contain unmapped paths even after a fallback to full classpath. Closes #18155. Commit cab7c6b PiperOrigin-RevId: 582014351 Change-Id: If9c51acb090d9fc4bc86052143ad9960e44fd8a7 Co-authored-by: Googler <gregce@google.com>
The changes in this PR have been included in Bazel 7.0.0 RC5. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Add end-to-end tests to verify that
--experimental_output_paths=strip
works with sandboxed, sandboxed worker, and remote execution and results in the desired cache hits. Also adapt and enableconfig_stripped_outputs_test
for Bazel (e.g. make it work on macOS).This requires a minor changes: We ensure that full
.jdeps
are rewritten to contain unmapped paths even after a fallback to full classpath.