Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on multiple output symlinks with BwoB #18207

Closed
wants to merge 1 commit into from
Closed

Fix crash on multiple output symlinks with BwoB #18207

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Apr 25, 2023

Fixes an issue introduced by ca30372.

Fixes bazel-contrib/rules_go#3545

@fmeum fmeum requested a review from a team as a code owner April 25, 2023 09:06
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 25, 2023

@bazel-io flag

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Apr 25, 2023
@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 25, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 25, 2023

@coeuvre Could you review this fix for a regression I introduced with #18075?

@fmeum fmeum mentioned this pull request Apr 25, 2023
Closed
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 25, 2023
@keertk
Copy link
Member

keertk commented Apr 25, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io mentioned this pull request Apr 25, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 25, 2023
@fmeum fmeum deleted the fix-only-element branch April 26, 2023 06:32
@keertk keertk mentioned this pull request Apr 26, 2023
Merged
keertk added a commit that referenced this pull request Apr 26, 2023
@keertk @fmeum
Fix crash on multiple output symlinks with BwoB (#18226)
3624c74 
Fixes an issue introduced by ca30372.

Fixes bazel-contrib/rules_go#3545

Closes #18207.

PiperOrigin-RevId: 527160752
Change-Id: I8baa3b8f855e22226ba83155e56fd9889a1f2051

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 27, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@fmeum @fweikert
Fix crash on multiple output symlinks with BwoB
4e34702 
Fixes an issue introduced by ca30372.

Fixes bazel-contrib/rules_go#3545

Closes bazelbuild#18207.

PiperOrigin-RevId: 527160752
Change-Id: I8baa3b8f855e22226ba83155e56fd9889a1f2051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rules_go is broken with Bazel@HEAD on Bazel CI
5 participants
@fmeum @keertk @coeuvre @bazel-io @sgowroji