Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/3] Bump grpc from 1.47.0 to 1.48.1 #18241

Closed
wants to merge 1 commit into from

Conversation

davido
Copy link
Contributor

@davido davido commented Apr 27, 2023

Previous PR: #18240

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 27, 2023
@davido davido changed the title Grpc 1 48 1 part 2 [2/3] Bump grpc from 1.47.0 to 1.48.1 Apr 27, 2023
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Apr 28, 2023
@davido davido force-pushed the grpc_1_48_1_part_2 branch from 64a07ae to 79d7132 Compare April 28, 2023 05:17
@meteorcloudy
Copy link
Member

@davido Please rebase so that we can merge this one!

@davido davido force-pushed the grpc_1_48_1_part_2 branch from 79d7132 to 05190a1 Compare April 28, 2023 12:19
@davido
Copy link
Contributor Author

davido commented Apr 28, 2023

@meteorcloudy

Please rebase so that we can merge this one!

Done.

@meteorcloudy
Copy link
Member

Should we also upgrade grpc in the MODULE.bazel file?

@meteorcloudy meteorcloudy self-requested a review April 28, 2023 12:20
@davido
Copy link
Contributor Author

davido commented Apr 28, 2023

Should we also upgrade grpc in the MODULE.bazel file?

Done.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 28, 2023
@Pavank1992
Copy link
Contributor

HI @davido, As the PR is approved for merge, could you please squash the commits to one so we can proceed? Thanks!

PART 2: switch to v1.48.1
Composed PR: bazelbuild#18216.
@davido davido force-pushed the grpc_1_48_1_part_2 branch from 232648f to 82967be Compare April 28, 2023 13:32
@davido
Copy link
Contributor Author

davido commented Apr 28, 2023

@Pavank1992 Squashed, done.

copybara-service bot pushed a commit that referenced this pull request Apr 29, 2023
PART 2: switch to v1.48.1
Composed PR: #18216.

Partial commit for third_party/*, see #18241.

Signed-off-by: Pavan Singh <pavanksingh@google.com>
@Pavank1992
Copy link
Contributor

Pavank1992 commented Apr 29, 2023

Third-party changes Merged at 1a4da7f

@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 2, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Previous PR: bazelbuild#18240

Closes bazelbuild#18241.

PiperOrigin-RevId: 528053742
Change-Id: I360b0b1db6ff22464939bfa388b185c980dd4ec4
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
PART 2: switch to v1.48.1
Composed PR: bazelbuild#18216.

Partial commit for third_party/*, see bazelbuild#18241.

Signed-off-by: Pavan Singh <pavanksingh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants