Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility issue of googleapis and remoteapis with Bzlmod enabled #19057

Closed
wants to merge 1 commit into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Jul 25, 2023

@// won't work with Bzlmod enabled.

Working towards #18957

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jul 25, 2023
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jul 25, 2023
@sgowroji
Copy link
Member

Hi @Wyverald, Since I can see that this PR has been approved, please let me know whether I should proceed with importing it.Thanks !

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 26, 2023
@meteorcloudy
Copy link
Member Author

@sgowroji Please help merge!

copybara-service bot pushed a commit that referenced this pull request Jul 26, 2023
Partial commit for third_party/*, see #19057.

Signed-off-by: Pavan Singh <pavanksingh@google.com>
@meteorcloudy
Copy link
Member Author

Merged at 8bcc908

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants