-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Bzlmod for Bazel #19087
Enable Bzlmod for Bazel #19087
Conversation
019e7ba
to
3f84a7e
Compare
c0fad89
to
8456291
Compare
f389962
to
f2378ce
Compare
26cae5c
to
4e46ee3
Compare
1627e1d
to
be0dcde
Compare
Avoid hard code rules_cc canonical repo name Update lockfile Fix workspace_resolved_test and test_repo cache Fix naming Fixes Fetch test repos concurrently Reuse repository cache Fix windows Fix rules_cc path Don't use hard link for repo cache inside tests The flag is causing "Invalid cross-device link" error for some reason Revert shard for macos_arm64 Update rules_python to match Bzlmod Update bazel_skylib to match Bzlmod Add bazel_skylib in workspace suffix (required by rules_python since 0.22.0) Fix bazel_determinism_test Update protobuf url to match Bzlmod Update rules_pkg to match bazel_determinism_test: use default repo cache Allow rules_proto tests to access internet declare local_config_cc Disable windows_arm64 temporarily Refactor CI flags Don't use /Users/pcloudy in bazelrc Revert "Disable windows_arm64 temporarily" This reverts commit cba92fd. Fix bazel_sandboxing_networking_test Polish MODULE.bazel pkg_tar: use strip_prefix properly Update lockfile Use --experimental_downloader_config to improve stability Add the original URL as well Polish Polish more
be0dcde
to
33bcfa1
Compare
e47d129
to
72f4a3a
Compare
android_ndk_repository/android_ndk_repository/' WORKSPACE | ||
- rm -f WORKSPACE.bak | ||
android_ndk_repository/android_ndk_repository/' WORKSPACE.bzlmod | ||
- rm -f WORKSPACE.bzlmod.bak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we creating this .bak
in the first place if we delete it right away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just for compatibility with macOS, where sed
doesn't support in-place replacing without a .bak
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is nitpicking (so feel free to leave as is), but why not do this weird pattern only on Mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know the original reason, but I guess it's just easier to keep them the same so you can search and edit all places just one time when you need some changes. We can clean this up in another PR if necessary.
32752df
to
e070a9b
Compare
I'm importing this PR as a CL to review, just in case it needs some tweak internally. |
This PR enables Bzlmod as the default external dependencies system for Bazel.
Changes included:
.bazelrc
.io_bazel
to_main
at necessary locations.MODULE.bazel.lock
. We should enable--lockfile_mode=error
on CI and--lockfile_mode=update
for local builds after fixing some issues in the lock file feature, probably with 6.4.0.--override_repository
hack with repository cache (http artifact cache) for running integration tests without network access. This will eventually be replaced by a true shared repository cache.--experimental_repository_cache_hardlinks
inside integration test to avoidinvalid cross-device link
. Because the file system of the sandbox dir is different from the repo cache dir.Next step:
Fixes #18957