Switch xcode_autoconf to use 'configure = True' #19121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'local = True' seems to run this too frequently. Realistically the user's installed Xcode versions don't change very often so similar to cc_autoconf this should be ok.
|
related conversation https://bazelbuild.slack.com/archives/CD3QY5C2X/p1690503980809849 |
github-actions
bot
added
the
awaiting-review
mattrobmattrob
approved these changes
Jul 28, 2023
thii
approved these changes
Jul 28, 2023
googlewalt
approved these changes
Aug 3, 2023
aiuto
added
the
awaiting-PR-merge
github-actions
bot
removed
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Aug 4, 2023
Using 'local = True' seems to run this too frequently. Realistically the user's installed Xcode versions don't change very often so similar to cc_autoconf this should be ok. Closes bazelbuild#19121. PiperOrigin-RevId: 553557177 Change-Id: I66368ec31d97badd24814aa13177261099e56dc7
Wyverald
pushed a commit
that referenced
this pull request
Aug 4, 2023
Using 'local = True' seems to run this too frequently. Realistically the user's installed Xcode versions don't change very often so similar to cc_autoconf this should be ok. Closes #19121. PiperOrigin-RevId: 553557177 Change-Id: I66368ec31d97badd24814aa13177261099e56dc7 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
|
The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 'local = True' seems to run this too frequently. Realistically the user's installed Xcode versions don't change very often so similar to cc_autoconf this should be ok.